If you define Zeff in that way, it is quite different from Slater's definition, and it is not surprising that you get different values. In my view it is not a very meaningful definition, because as I said P is not a Rydberg atom. When you remove an electron the interactions between the remaining electrons change, so you get different Zeff values for P+ and P2+. (You do with Slater as well.)